Skip to content

[luv-cut-1.0.0-beta.2] Cut 1.0.0-beta.2 - #636

Open
NiveditJain wants to merge 1 commit into
failproofaidfrom
luv-cut-1.0.0-beta.2
Open

[luv-cut-1.0.0-beta.2] Cut 1.0.0-beta.2#636
NiveditJain wants to merge 1 commit into
failproofaidfrom
luv-cut-1.0.0-beta.2

Conversation

@NiveditJain

Copy link
Copy Markdown
Member

Release cut for 1.0.0-beta.2 — version only (package.json, Cargo.toml, Cargo.lock).

Based on failproofaid (#632) rather than main, so the diff is just the version lines; the work itself is reviewed there.

Cargo.lock moves with the other two because the release build runs cargo build --locked, which hard-errors when the lockfile records a different workspace version than Cargo.toml.

What this release ships

  • sudo failproofai config is gone as advice — and the wizard now refuses to run under sudo when SUDO_USER shows a real user behind it. Under sudo, homedir() is /root: hooks land in root's settings, daemonConfigured is set for root, the binary downloads to /root/.failproofai/bin, and the unit carries User=root.
  • Service install is step 0, before every other question, because it is the only step needing a password. sudo -v prompts on a clean terminal and caches the credential, so the install itself stays non-interactive instead of firing an invisible prompt under a drawn TUI frame.
  • Three review findings in the system-service install, all introduced with it: a guessable staging path in the shared temp dir that writeFileSync would follow a symlink through (local root-write vector), an unquoted FAILPROOFAI_WORKER_CMD that broke on any path with a space (the daemon runs it through sh -c), and a launchd label that was not per-user, so a second Mac user's install overwrote the first's daemon.

Verified

Published through publish.yml — dry run, then live:

  • npm next: 1.0.0-beta.2; beta (0.0.15-beta.1) and latest (0.0.15) untouched
  • prerelease v1.0.0-beta.2 with four .gz binaries + SHA256SUMS
  • main's version untouched

🤖 Generated with Claude Code

https://claude.ai/code/session_01EbXKFnpRXBwsrvUJDdySky

Version only, on a `luv-cut-*` branch, with Cargo.toml and Cargo.lock
moving together — the release build runs `cargo build --locked`, which
hard-errors when the lockfile records a different workspace version.

Ships the config-flow fix (sudo prompted in-process at step 0, and the
wizard refusing to run under sudo at all) plus three review findings in
the system-service install: a symlink-able staging path for the
privileged write, an unquoted FAILPROOFAI_WORKER_CMD that broke on any
path with a space, and a launchd label that was not per-user.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EbXKFnpRXBwsrvUJDdySky
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b3dfeaa4-bb05-4347-bc84-a5c2a11de496

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant