fix(windows): detach shell protocol stdin - #458
Merged
Merged
Conversation
FerroxLabs
changed the base branch from
fix/vision-credential-binding
to
main
September 9, 2026 09:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Desktop Core reads its host protocol from stdin. Shell children inherited that same actively-read pipe, blocking Git Bash during MSYS initialization in
NtQueryObjectbefore evenbun --versionexecuted. Give noninteractive Windows shell commands null stdin in the shared command builder used by buffered and streaming Job Object execution.The regression keeps a host-input pipe open with a pending reader and exercises both production backend paths. Both target tests fail on c98b58c and pass with this change. Job Object ownership, environment filtering, shell selection and timeout limits remain intact. Unix behavior is unchanged.
Validation: native Windows regression4/4, existing backend6/6 and Job Object7/7, Windows all-target crate Clippy, and the normal just-push gate passed18,071 tests/104 skips. The full run reported3 flaky memory-bootstrap tests and1 leaky real-zombie test; receipts preserve those outcomes. The corrected Desktop candidate passes the exact previously timing-out Bun-version call and completes that turn. Guided TIDE confirmation passes74/74 valid chart quotes/panels,0unread, exact chart/pane/studies/watchlist restoration, registered HTML Open here and healthy conversation reopening. Artifact placement used a byte-identical copy into the managed namespace. No signed-release claim.
Includes the independently qualified vision/hint correction in #457 until it integrates; the additional delta is only the Windows stdin fix and its regression. Targets main for the required full CI.