ci: let the verification gate skip Windows signing - #1074
Open
FerroxLabs wants to merge 1 commit into
Open
FerroxLabs wants to merge 1 commit into
FerroxLabs wants to merge 1 commit into
Conversation
build-matrix.yml has never once completed a Windows build, and the reason was never time. It holds no Azure credentials by design, electron-builder declares win.azureSignOptions unconditionally, and the Azure EnvironmentCredential falls through to an INTERACTIVE flow when the three secrets are absent. Every Windows target therefore sat silent for 107 minutes at 'signing with Azure Trusted Signing' - AFTER its output was already written - until the job timeout killed it and reported CANCELLED, which reds out identically to a real failure. Raising the timeout 60 -> 120 did not help, because nothing was progressing. A verification build does not need a signature. This is the Windows counterpart of the CSC_IDENTITY_AUTO_DISCOVERY opt-out the same step already sets for macOS. The release path is untouched: it supplies real credentials and already fails closed when AZURE_CLIENT_SECRET is empty on a tag. The hazard is the opt-out LEAKING onto that path and quietly shipping an unsigned installer, so it is guarded twice. At runtime, resolveWindowsSigningOptOut throws on refs/tags/* and on refs/heads/dev - the two refs build-and-release.yml fires on. At rest, a test pins the flag present in the gate and absent from all three release workflows. The decision is a pure exported function so this is a behaviour test rather than a source-string match; the test loads the CommonJS module through createRequire, since its top-level return defeats vitest's ESM transform. Both guards are mutation-verified: leaking the flag into _build-reusable.yml fails the test, and deleting the tag/dev refusal fails it too. Full suite: 18,757 passed, 0 failed.
github-actions
Bot
added
area:packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-matrix.yml has never once completed a Windows build, and the reason was never time. It holds no Azure credentials by design, electron-builder declares win.azureSignOptions unconditionally, and the Azure EnvironmentCredential falls through to an INTERACTIVE flow when the three secrets are absent. Every Windows target sat silent for 107 minutes at 'signing with Azure Trusted Signing', AFTER its output was already written, until the job timeout killed it and reported CANCELLED, which reds out identically to a real failure. Raising the timeout from 60 to 120 did not help because nothing was progressing.
A verification build does not need a signature. This is the Windows counterpart of the CSC_IDENTITY_AUTO_DISCOVERY opt-out the same step already sets for macOS.
The release path is untouched. It supplies real credentials and already fails closed when AZURE_CLIENT_SECRET is empty on a tag. The hazard is the opt-out leaking onto that path and quietly shipping an unsigned installer, so it is guarded twice: at runtime resolveWindowsSigningOptOut throws on refs/tags/* and refs/heads/dev, the two refs build-and-release.yml fires on; at rest a test pins the flag present in the gate and absent from all three release workflows.
The decision is a pure exported function so this is a behaviour test rather than a source-string match. Both guards are mutation-verified: leaking the flag into _build-reusable.yml fails the test, and deleting the tag/dev refusal fails it too.
Full suite: 18,757 passed, 0 failed. Deliberately kept separate from the 0.12.1 release so it cannot perturb the build in flight.