fix(wcore): preserve workspace receipts and inherited approvals - #1329
Closed
FerroxLabs wants to merge 1 commit into
Closed
FerroxLabs wants to merge 1 commit into
FerroxLabs wants to merge 1 commit into
Conversation
github-actions
Bot
added
area:desktop-ui
Owner
Author
|
Closing as obsolete: this targets Wayland Core / Nano code that was removed in the 0.13.0 cutover. As of 0.13.1 Fuigo is the only engine, so these files no longer exist on main and the change cannot be rebased. If the underlying behaviour still matters under Fuigo, it is worth a fresh issue against the current code rather than reviving this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core workspace-policy receipts currently disappear at the manager’s empty-message guard, leaving the chat without filesystem-access evidence. This change preserves accepted receipts and exposes live readable/writable roots and executable capabilities beside the permission selector; dead or disposing sessions report unknown access. Raw stream payloads only trigger a fresh main-process read.
The Tools pane now preserves an absent allow-list as inherited instead of writing a hardcoded default list when a setting changes. Inherited per-tool states remain unknown, and independent registration gates remain editable. Existing explicit custom lists still round-trip.
Related to #1188. This is an intermediate repair: producer-backed tool inventory, mode effects and inheritance-preserving per-tool overrides remain tracked in #1328. The workspace receipt describes filesystem access and does not prove a tool’s registration or approval state. No issue closure is requested.
Validation: full Linux
bun run testpassed 21,470 Vitest tests (53 skipped) and 285 Bun-native tests; typecheck passed against the exact committed tree. Focused macOS receipt/settings/access tests passed 142 cases, plus all 24 voice integration cases. Both receipt-drop and default-materialization regression tests failed before the fixes. Repository lint has the existing 3,017 warnings and zero errors; i18n and the complete local prek checks passed. The initial full run exposed a missing mock for the new access control in the voice harness; its evidence was retained and the corrected full run passed with no source drift. Native packaged user-flow acceptance remains pending.