fix(wcore): wait for confirmed approval mode changes - #1330
Closed
FerroxLabs wants to merge 1 commit into
Closed
FerroxLabs wants to merge 1 commit into
FerroxLabs wants to merge 1 commit into
Conversation
Owner
Author
|
Closing as obsolete: this targets Wayland Core / Nano code that was removed in the 0.13.0 cutover. As of 0.13.1 Fuigo is the only engine, so these files no longer exist on main and the change cannot be rebased. If the underlying behaviour still matters under Fuigo, it is worth a fresh issue against the current code rather than reviving this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing Core from Default to an automatic approval mode currently updates Desktop’s local approval authority and reports success before Core accepts the command. A later typed refusal is dropped, leaving the permission selector and host-side approvals out of sync with Core.
This change keeps the previous mode until an accepted policy/config receipt arrives, consumes
set_mode_refused, and returns the effective mode on rejection. Overlapping requests, disconnected transports and unconfirmed requests fail without widening approval authority. Temporary scheduled-run mode changes remain unpersisted. The renderer explains the refusal, refreshes main-process truth, ignores delayed results from another conversation and prevents a capability-label refresh from reinstating an old stored preference.Related to #1223. A mode refusal does not itself disable tools; the UI says that explicitly rather than inventing a tool inventory. Producer-backed per-tool availability remains the separate #1328 contract dependency. No issue closure is requested.
Validation: exact committed tree
5e3cdf68c18faa88215a9bba3002e0ad2723f3bfpassed full Hetzner verification: 21,472 Vitest tests (53 skipped), 285 Bun tests and typecheck, with no source drift. Local focused manager/decoder/renderer suites pass 76 tests. Regression tests reproduce premature local elevation and stale stored-mode restoration before their fixes; accepted and refused paths are both covered. Local typecheck, i18n validation, lint (existing 3,017 warnings, zero errors) and full prek checks pass. Remote setup errors and the initial missing nested dependency test failure were preserved before the corrected full run. Native packaged user-flow acceptance remains pending.