rust/ja4: eliminate temporary String allocations during HTTP/1 header filtering - #312
Open
Aditya-9-6 wants to merge 3 commits into
Open
rust/ja4: eliminate temporary String allocations during HTTP/1 header filtering#312Aditya-9-6 wants to merge 3 commits into
Aditya-9-6 wants to merge 3 commits into
Conversation
Signed-off-by: Aditya <adityadahale96@gmail.com>
…atting Signed-off-by: Aditya <adityadahale96@gmail.com>
vlvkobal
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines two zero-allocation memory optimizations across
rust/ja4:rust/ja4/src/http.rs): Replacess.split(':').next().unwrap().to_owned()ands.to_lowercase().as_str()with zero-allocationname.eq_ignore_ascii_case("cookie")andname.eq_ignore_ascii_case("referer")checks.rust/ja4/src/tcp.rs): Replaces intermediateVec<String>allocations duringoptionsformatting (self.options.iter().map(|v| v.to_string()).collect::<Vec<_>>().join("-")) with direct formatting into a pre-allocatedStringbuffer.Rationale & Performance Benefit
In high-throughput packet processing loops, allocating temporary
Strings andVecs per packet creates memory allocation pressure.By eliminating intermediate heap allocations: