Issue 697 mobile fee estimation - #880
Merged
ONEONUORA merged 7 commits intoSep 1, 2026
Merged
Conversation
… authorizations - Add Nonce(Address) storage key for per-user nonce tracking - Add NonceAlreadyUsed and InvalidSignature error types - Implement get_nonce() to query current user nonce - Implement pay_with_signature() for off-chain signed payments * Validates nonce matches current on-chain value * Increments nonce on successful execution * Verifies Ed25519 signature * Prevents replay attacks - Add SignedPaymentAuth struct for authorization payload - Add comprehensive test coverage for nonce behavior - Document implementation in NONCE_IMPLEMENTATION.md Acceptance Criteria: ✅ Store Nonce(Address) in storage ✅ Increment user nonce on successful payment execution ✅ Reject reused nonces with proper error handling
|
@Toromo7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ONEONUORA
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the mobile transfer confirmation flow to display the network base fee and Soroban resource fee breakdown before signing, and cleans up the local TypeScript/Jest environment issues that were blocking validation.
Why
The app previously did not give users a clear view of the fee composition before signing a transaction, which could lead to confusion around what is being charged. The local environment also had issues preventing reliable validation of the mobile app and TypeScript config.
Validation
Verified the targeted Jest test passes:
node .\node_modules\jest\bin\jest.js --runInBand tests/TransferConfirmationCard.test.tsx
Result: test suite passed successfully
Confirmed no editor diagnostics remain in the TypeScript config after the cleanup
Closes #697