Final resource reload optimization - #73
Merged
Merged
Conversation
Cuts 60ms of lang-related time (-44%) and 165mb of allocations (-41%)
Cuts 22ms of buildIndex (-17%) and 52mb allocations (-32.5%)
doesn't affect perf; cuts 40mb of buildIndex or -37%
saves 15mb and deduplicates some code
for scanZipPack: -21ms (-24%) and -112mb (-48%)
ABKQPO
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overall GuideNH reload work went from 574 ms to 413 ms (-28%), with sampled allocations dropping from 649 MiB to 303 MiB (-53%).
.langfiles only oncebuildIndex: -22 ms (-17%), -52 MiB (-32.5%).langfilesbuildIndex: -40 MiB (-37%)scanZipPack: -21 ms (-24%), -112 MiB (-48%)Checklist