Don't tick afk on utility/broken packets - #220
Merged
Merged
Conversation
hinyb
approved these changes
Sep 3, 2026
hinyb
left a comment
hinyb
left a comment
There was a problem hiding this comment.
LGTM! I pushed a quick commit to include RobotStateRequest to save us a round trip. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR stops ticking the afk timer on utility or broken client packets that opencomputers' server recieves.
Some more context
In my playthrough (GTNH 2.8.4), building an oc computer just breaks the afk detection in like 4-5 chunk radius, I narrowed it down to
TextBufferInitpacket from opencomputers mod, which does not seem to be a result of any player interaction and is sent very frequently for seemingly no reason. Not sure what's the real underlying issue on why it is being sent so much, nor have I dug deep enough to understand the use of it, but it 100% should not tick the afk timer.Checklist