⬆️ dep-bump: cap unxt below 2.0 - #800
Merged
Merged
Conversation
galax declares `unxt>=1.11.2` with no upper bound, but has never been resolved or tested against unxt 2.x -- the lock has only ever held a 1.x. Today nothing declares that boundary: `uv` considers unxt 2.0.0 during resolution (it is compatible on `requires-python`) and backtracks to 1.11.x for transitive reasons. That is incidental, not a guarantee, and it disappears the moment the surrounding constraints shift. Make the tested boundary explicit. The resolved version is unchanged -- 1.11.2, as before -- so this is metadata only; `uv.lock` records the new specifier and nothing else. There is a concrete change coming that this guards against. unxt is making unit system `repr`/`str` round-trippable (GalacticDynamics/unxt#855), which rewrites the `LTMAUnitSystem( length=Unit("kpc"), ...)` form that 32 doctest lines here pin, 18 of them in `_interop/galax_interop_gala/potential.py` and 12 in `..._galpy/potential.py`. Those updates belong with the port to unxt 2.x, not ahead of it. Lift this cap in the PR that does that port. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 160 160
Lines 6046 6046
=======================================
Hits 5796 5796
Misses 250 250 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
galaxdeclaresunxt>=1.11.2with no upper bound, but has never beenresolved or tested against unxt 2.x — the lock has only ever held a 1.x.
Nothing currently declares that boundary.
uvdoes consider unxt 2.0.0during resolution (it is compatible on
requires-python) and backtracks to1.11.x for transitive reasons. That is incidental rather than a guarantee, and
it disappears as soon as the surrounding constraints shift — a coordinax bump,
a new dependency, an
--upgrade.This makes the tested boundary explicit. The resolved version is unchanged
— 1.11.2, as before — so the diff is metadata only:
What it guards against
unxt is making unit-system
repr/strround-trippable(GalacticDynamics/unxt#855):
reprunitsystem(kpc, …)orLengthUnitSystem(length=Unit("km"))unitsystem('kpc', 'Myr', 'solMass', 'rad')strLTMAUnitSystem(length, time, mass, angle)unitsystem(kpc, Myr, solMass, rad)That rewrites the
LTMAUnitSystem( length=Unit("kpc"), ...)form which 32doctest lines here pin — 18 in
_interop/galax_interop_gala/potential.py, 12in
_interop/galax_interop_galpy/potential.py, and one each inpotential/_src/builtin/burkert.pyandpotential/_src/params/field.py.Those updates belong with the port to unxt 2.x rather than ahead of it, since
2.0 already carries its own breaking changes (no-arg
unitsystem()is nowdimensionless, unit-system identity is order-independent, Python 3.11 dropped).
Lift this cap in the PR that does that port.
Verification
uv lockproduces no resolved-version change.tests/smoke8 passed;tests/unit1032 passed, 170 skipped, 14 xfailed.