Fix: Skip settings sync for archived repositories - #4
Draft
StephHope wants to merge 1 commit into
Draft
Conversation
Archived repos are read-only on GitHub, so running the repository and child plugins (rulesets, branches, etc.) against them just produced repeated "Repository was archived so is read-only" errors on every sync, including on the hourly cron. updateRepos now checks archive state up front and skips the rest of the sync for a repo that is archived and not being unarchived. The archive-state check runs inside the same nop-aware try/catch used elsewhere in the method, so a transient failure there (e.g. a rate limit) still degrades gracefully per-repo in NOP/PR-comment mode instead of aborting the whole sync run. Addresses github-community-projects#443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#25858
Archived repos are read-only on GitHub, so running the repository and child plugins (rulesets, branches, etc.) against them just produced repeated "Repository was archived so is read-only" errors on every sync, including on the hourly cron.
updateRepos now checks archive state up front and skips the rest of the sync for a repo that is archived and not being unarchived. The archive-state check runs inside the same nop-aware try/catch used elsewhere in the method, so a transient failure there (e.g. a rate limit) still degrades gracefully per-repo in NOP/PR-comment mode instead of aborting the whole sync run.
Addresses github-community-projects#443