feat!: migrate populate outbox job to job crate - #658
Merged
Merged
Conversation
krtk6160
force-pushed
the
feat--job-crate-migration
branch
from
October 20, 2025 09:40
7654cba to
ea251f9
Compare
| let config = PopulateOutboxJobConfig { | ||
| account_id, | ||
| journal_id, | ||
| tracing_data: crate::tracing::extract_tracing_data(), |
Member
There was a problem hiding this comment.
I think this shouldn't be necessary anymore as the job crate has support for tracing OOTB - can you check on honeycomb?
Member
Author
There was a problem hiding this comment.
I tested after removing this field and the traces still appeared on honeycomb, so have removed this.
bodymindarts
approved these changes
Oct 22, 2025
krtk6160
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.