refactor(pagination)!: bump es-entity to 0.14.1, job to 0.16.1, obix to 0.13.1 - #892
Merged
nicolasburtey merged 1 commit intoSep 23, 2026
Merged
Conversation
…to 0.13.1 Migrates to the es-entity 0.14 pagination API (Page enum, accessor methods for has_next_page/end_cursor, into_end_cursor) as adapted from #889, now against the published crates.io releases. - es-entity 0.13.0 -> 0.14.1 - job 0.15.2 -> 0.16.1 - obix 0.12.3 -> 0.13.1 (es-entity-macros + sqlparser 0.63 ride along) Part of the release-crate-chain roll: es-entity -> job -> obix -> cala -> lana-bank.
Contributor
📊 Performance ReportCommit: 8e58777 Cala Performance Benchmark Results (non-representative)Criterion Benchmark Results (single-threaded)
Load Testing Results (parallel-execution)
Note: Performance results may vary based on system resources and database state. Last updated by commit 8e58777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates cala to the released chain versions. Migration code adapted from #889 (whose Check Code failure was a Magic Nix Cache rate-limit flake; its Integration Test passed).
Pageenum,has_next_page()/end_cursor()accessors,into_end_cursor())Part of the release-crate-chain roll: es-entity -> job -> obix -> cala -> lana-bank.
Note
Medium Risk
Breaking pagination API changes affect every es-entity list path; behavior should be unchanged if tests pass, but cursor continuation and “has next page” semantics are easy to get wrong during migration.
Overview
Bumps the workspace dependency chain to
es-entity0.14.1,job0.16.1, andobix0.13.1 (with matchingCargo.lock/fuzz/Cargo.lockupdates, including transitivesqlparser0.63.0).Adapts cala to es-entity’s breaking pagination API: paginated results no longer use
into_parts()orhas_next_page/end_cursorfields. Call sites now useinto_page()with thePage::Last/Page::HasNextenum,has_next_page(),end_cursor(), andinto_end_cursor()for cursor continuation.Production:
Entries::list_for_transaction_idunpacks the repo page viainto_page()before sorting by sequence.Tests: shared
helpers::expect_single_pagefor single-page assertions; pagination tests (account set members, effective-balancelist_modified_since, filtered entries) updated to the new accessors and multi-page loops viaPage::HasNext.Reviewed by Cursor Bugbot for commit 8e58777. Configure here.