feat: prototype commit finalizers for operation-wide publication - #226
Draft
nicolasburtey wants to merge 1 commit into
Draft
nicolasburtey wants to merge 1 commit into
nicolasburtey wants to merge 1 commit into
Conversation
Drain all ordinary and reentrant hooks before running finalizers. Keep finalizers mergeable while publications accumulate, and roll back if a finalizer attempts to register any further hook. Exercise late generations and rejection of publication after sealing.
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PoC lifecycle support for operation-wide outbox publication envelopes. Independent publishers can register work during different/reentrant commit-hook generations; an ordinary merged hook cannot know that it has seen the final contribution.
CommitHook::is_finalizer()(default false).This is the upstream lifecycle dependency for Obix #149 and Lana DW integration #8871. Based on release 0.12.21 to match the integration's dependency graph. No Cala patch is needed.
Validation
SQLX_OFFLINE=true cargo check -p es-entity --libpasses.git diff --checkpass.clippy::useless_conversionfindings insrc/query.rs:86,96. Changed library/test targets pass with--no-deps -- -D warnings -A clippy::useless_conversion.Scope
Draft architectural PoC, not a release request. Finalizers may perform SQL but cannot register more hooks. Multiple finalizers taking shared locks still need a canonical lock order in callers; this phase is not a deadlock-avoidance mechanism.