Conversation
Bumps the workspace `es-entity` pin 0.12.14 -> 0.13.0. The 0.13.0 breaking change (`PaginatedQueryRet` gated behind constructor and accessor methods) does not touch this crate's source. Blocked on the `job` release: `job` 0.14.0 is still built against es-entity 0.12, so the lock now resolves both 0.12.21 and 0.13.0 and the crate does not compile across the obix/job boundary. The `job` pin must move to the next job release (built on es-entity 0.13) before this can merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the workspace
es-entitypin 0.12.14 → 0.13.0 (release notes), withCargo.lockpicking upes-entity-macros0.13.0. This is theobixstep of the rollout chain (es-entity → job → obix → cala → lana-bank).Draft: blocked on a
jobrelease built against es-entity 0.13. See below.Breaking change does not touch this crate
0.13.0 is a breaking 0.x release:
PaginatedQueryRetloses its publicentitiesfield and can no longer be built by struct literal — callers now usePaginatedQueryRet::new(...),.entities(),.into_parts(),.map_entities(),.try_map_entities()and.map_end_cursor(). No source in this repo constructs that struct by literal or reads the field, so no code changes are needed for the breaking change itself.Why this is a draft
job0.14.0 (the current crates.io release, still pinned here) depends on es-entity 0.12, so with this bump cargo resolves two es-entity versions side by side —0.12.21forjoband0.13.0forobix— and the crate no longer compiles across the obix/job boundary.cargo check --all-featuresfails with 25 errors, all of the same shape:E0277—DbOp<'_>: es_entity::operation::AtomicOperationnot satisfiedE0277—impl es_entity::AtomicOperation: es_entity::operation::AtomicOperationnot satisfiedE0277—ctx::FlushOp<'_>: es_entity::operation::AtomicOperationnot satisfiedE0308— mismatched types, e.g.job::JobCompletion::CompleteWithOpexpectses-entity-0.12.21'sDbOp<'static>but getses-entity-0.13.0'sDbOp<'_>with rustc noting
there are multiple different versions of crate es_entity in the dependency graphon every one. These are purely the two-version split, not real API breakage.What unblocks it
GaloyMoney/job#218 bumps
jobto es-entity 0.13.0. Once that merges and ajobrelease is cut, thejobpin here (job = { version = "0.14.0", features = ["es-entity"] }) must be bumped to that release; the lock then collapses back to a single es-entity 0.13.0 and this should compile clean. I deliberately left thejobpin untouched rather than guessing an unreleased version number. This PR should be re-checked and taken out of draft at that point — do not merge it before then.Local validation
Run in
nix develop, withSQLX_OFFLINE=true:cargo fmt --check— cleancargo clippy --all-features --all-targets— fails with the 25 two-version errors above; nothing elsecargo update -p es-entity -p es-entity-macrosproduced a lock diff touching onlyes-entity,es-entity-macrosandconvert_casefuzz/needs no change: unlikejob's fuzz crate, it does not pin es-entity directlyIntegration tests were not run locally (no Postgres in this environment).
🤖 Generated with Claude Code