Skip to content

[AI] What to change: The Payment page under Settings for Admin. - #213

Open
burkongla wants to merge 1 commit into
mainfrom
agent/slack-070ac24f-what-to-change-the-payment-page-under-se
Open

[AI] What to change: The Payment page under Settings for Admin.#213
burkongla wants to merge 1 commit into
mainfrom
agent/slack-070ac24f-what-to-change-the-payment-page-under-se

Conversation

@burkongla

Copy link
Copy Markdown
Contributor

Automated PR

Task: What to change: The Payment page under Settings for Admin.
Description: What to change: The Payment page under Settings for Admin.
• User tab: When you have registered a new project, make sure that there are no checked boxes under “Payment options”, and the all fields under “Ticket cost” are shown as 0,00.
• Helper tab: When you have registered a new project, make sure that the “Sharing ratio” under Team is 100% for “Payment to team-member” and 0% “Payment to project”, by default. Let the “Sharing ratio” under Community be 100% for “Payment to community helper” and 0% “Payment to project”. Let the “External Consultants and Companies” have the signal button “Payment outside Githelp” chosen as default, with the same 100% and 0% distribution for the payment share.
Do not change: Anything else than what is listed.
Acceptance criteria: When all points listed under “Description and specific values” are implemented the task is done
Source: slack
Requested by: U04E9DZ5ELF
Classification: mixed

Changes

Change the default payment settings for newly registered projects so the User tab shows no checked Payment options and 0.00 ticket costs, and the Helper tab defaults to 100%/0% sharing ratios for Team, Community, and External Consultants with 'Payment outside Githelp' preselected. Requires a backend migration altering column defaults on projects_payment_settings, plus aligning the frontend page's client-side fallback/initial values.

Security Review

Status: warn
No OWASP-pattern vulnerabilities or dependency changes, but the diff silently flips payment defaults to 100% helper / 0% project and $0.00 pricing for projects without saved settings — a client-trusted financial misconfiguration risk that should be validated server-side. Advisory warn, not a block.

Warnings:

  • src/app/settings/payment/page.tsx: Revenue-split defaults changed from 50/50 (team), 85/15 (community), 70/30 (consultant) to 100/0 across all three tiers. For any project whose payment_settings row doesn't yet exist, the form now pre-fills 100% to the helper and 0% to the project. If a user saves without adjusting, the project owner's revenue share is silently persisted as zero. This is a business-logic integrity risk: defaults for money-splitting values should be conservative and enforced server-side, not trusted from client-side form state.
  • src/app/settings/payment/page.tsx: Ticket pricing fallbacks changed from paid defaults (1000/150/100 cents) to ?? 0. When ticket_start_price / per-minute prices are NULL in the database, the form now displays $0.00 and, if saved, persists free support pricing. Combined with the 100/0 split change, a fresh project that saves this page once ends up with zero pricing and zero project revenue — a silent financial misconfiguration path.
  • src/app/settings/payment/page.tsx: Fallback for extended_contract_type changed from "ticket" to "outside" (and the useState default at line 102 likewise). Projects with a NULL contract type silently switch behavior to 'outside contract' handling, which changes how consultant work is billed without any user action.

🤖 Generated by githelp-support agent team

Task: 070ac24f
Source: slack
Requested by: U04E9DZ5ELF
@netlify

netlify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploy Preview for githelp-support ready!

Name Link
🔨 Latest commit 374f5b8
🔍 Latest deploy log https://app.netlify.com/projects/githelp-support/deploys/6a8de2f8ad05bc00083e7738
😎 Deploy Preview https://deploy-preview-213--githelp-support.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant