[AI] What to change: The Payment page under Settings for Admin. - #213
Open
burkongla wants to merge 1 commit into
Open
[AI] What to change: The Payment page under Settings for Admin.#213burkongla wants to merge 1 commit into
burkongla wants to merge 1 commit into
Conversation
Task: 070ac24f Source: slack Requested by: U04E9DZ5ELF
✅ Deploy Preview for githelp-support ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR
Task: What to change: The Payment page under Settings for Admin.
Description: What to change: The Payment page under Settings for Admin.
• User tab: When you have registered a new project, make sure that there are no checked boxes under “Payment options”, and the all fields under “Ticket cost” are shown as 0,00.
• Helper tab: When you have registered a new project, make sure that the “Sharing ratio” under Team is 100% for “Payment to team-member” and 0% “Payment to project”, by default. Let the “Sharing ratio” under Community be 100% for “Payment to community helper” and 0% “Payment to project”. Let the “External Consultants and Companies” have the signal button “Payment outside Githelp” chosen as default, with the same 100% and 0% distribution for the payment share.
Do not change: Anything else than what is listed.
Acceptance criteria: When all points listed under “Description and specific values” are implemented the task is done
Source: slack
Requested by: U04E9DZ5ELF
Classification: mixed
Changes
Change the default payment settings for newly registered projects so the User tab shows no checked Payment options and 0.00 ticket costs, and the Helper tab defaults to 100%/0% sharing ratios for Team, Community, and External Consultants with 'Payment outside Githelp' preselected. Requires a backend migration altering column defaults on projects_payment_settings, plus aligning the frontend page's client-side fallback/initial values.
Security Review
Status: warn
No OWASP-pattern vulnerabilities or dependency changes, but the diff silently flips payment defaults to 100% helper / 0% project and $0.00 pricing for projects without saved settings — a client-trusted financial misconfiguration risk that should be validated server-side. Advisory warn, not a block.
Warnings:
?? 0. When ticket_start_price / per-minute prices are NULL in the database, the form now displays $0.00 and, if saved, persists free support pricing. Combined with the 100/0 split change, a fresh project that saves this page once ends up with zero pricing and zero project revenue — a silent financial misconfiguration path.🤖 Generated by githelp-support agent team