okf: write stackoverflow bundle tags as YAML lists - #293
Merged
amirhormati merged 1 commit intoAug 14, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
amirhormati
force-pushed
the
okf-tags-must-be-a-list
branch
from
August 14, 2026 17:10
1aaf9ba to
e7b4a48
Compare
Eight files gave `tags:` a bare comma-separated string, which YAML reads as one plain scalar, not a sequence. A JavaScript string is iterable, so the Documents Layout expanded each one into a Dataplex label per character, and these files round-tripped corrupted while the other 24 in the bundle were fine. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
amirhormati
force-pushed
the
okf-tags-must-be-a-list
branch
from
August 14, 2026 17:52
e7b4a48 to
de5089d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tags:in OKF frontmatter is meant to be a list. Eight files inokf/bundles/stackoverflowwrite it as a bare comma-separated string instead.A JavaScript string is iterable, so the Documents Layout iterates it anyway and
each character becomes a Dataplex label. Pushing
tables/votes.md(
tags: Stack Overflow, votes, posts, community) to Knowledge Catalog stored:No error, no warning. Those eight files round-tripped corrupted; the other 24
in the bundle were fine.
Fix
Rewrite the eight files as YAML flow sequences, matching the style the nine
acme_retailfiles already use:The brackets are the whole difference. Without them it is a plain scalar, not a
sequence.
Files changed:
datasets/stackoverflow.md,tables/posts_answers.md,tables/posts_moderator_nomination.md,tables/posts_questions.md,tables/posts_wiki_placeholder.md,tables/stackoverflow_posts.md,tables/users.md,tables/votes.mdBundle data only. #294 adds the library-side guard that makes this shape an
error instead of silent corruption; it should land after this PR, since these
are the files that trip it.
Verification
Against
hormati-bqml/us-central1, using the demo's push/pull path:tables/votesnow stores four labels (Stack Overflow,votes,posts,community) instead of fourteen single characters.Found while round-tripping the sample bundles for #292. #292, #293, and #294
share no files.