feat(airflow): Add semantic inference verification for MaxText E2E DAGs - #1364
Draft
chiajunglien wants to merge 1 commit into
Draft
chiajunglien wants to merge 1 commit into
chiajunglien wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue:
Currently, our Airflow E2E DAGs (e.g.,
maxtext_e2e_tpu_post_training.py) rely solely onexit 0to validate job success. However, during recent model testing (e.g., Llama3.1-70B and Gemma3-4B), we discovered "silent failures" where the inference process completes successfully but generates invalid text, nonsensical repetitions, or produces completely empty output.Changes:
validate_semantic_inference_outputtask that securely queries logs from Cloud Logging for the
workload-container.Generated text: output block,detect non-UTF-8 corruptions (
\ufffd), and ensure expected semantic keywords (e.g., Londonlandmarks) are present.
dags/multipod/util/validation_util.pytomaintain a clean directory structure.
Tests
https://06ba93284e31466eb62067a2f46710a7-dot-us-east1.composer.googleusercontent.com/dags/test_inference_validation/grid?search=test_inference_validation
Checklist
Before submitting this PR, please make sure (put X in square brackets):