Skip to content

chore: autocorrect rubocop offenses in appengine and jobs samples #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
torreypayne merged 2 commits into from
Aug 4, 2026
+15 −13
Merged

chore: autocorrect rubocop offenses in appengine and jobs samples #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e498af5
style: autocorrect rubocop offenses in appengine and jobs samples
torreypayne Jul 31, 2026
86ad1c9
chore: align compensation range formatting per code review
torreypayne Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine/rails-hello_world/bin/setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ require "fileutils"
# path to your application root.
APP_ROOT = File.expand_path "..", __dir__

def system!(*args)
def system! *args
system(*args) || abort("\n== Command #{args} failed ==")
end

Expand Down
2 changes: 1 addition & 1 deletion appengine/standard-static-files/rails/bin/setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ require "fileutils"
# path to your application root.
APP_ROOT = File.expand_path "..", __dir__

def system!(*args)
def system! *args
system(*args) || abort("\n== Command #{args} failed ==")
end

Expand Down
2 changes: 1 addition & 1 deletion appengine/static_files/rails/bin/setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ require "fileutils"
# path to your application root.
APP_ROOT = File.expand_path "..", __dir__

def system!(*args)
def system! *args
system(*args) || abort("\n== Command #{args} failed ==")
end

Expand Down
22 changes: 12 additions & 10 deletions jobs/V3/filter_search_sample.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,16 +230,18 @@ def job_discovery_compensation_search project_id:, company_name:, min_unit:, max
session_id: "HashedSessionId",
domain: "http://careers.google.com"
# Search jobs that pay between min_unit and max_unit (USD/hour)
compensation_range = jobs::CompensationRange.new max_compensation: (
jobs::Money.new currency_code: "USD",
units: max_unit,
nanos: 500_000_000
),
min_compensation: (
jobs::Money.new currency_code: "USD",
units: min_unit,
nanos: 0
)
compensation_range = jobs::CompensationRange.new(
max_compensation: jobs::Money.new(
currency_code: "USD",
units: max_unit,
nanos: 500_000_000
),
min_compensation: jobs::Money.new(
currency_code: "USD",
units: min_unit,
nanos: 0
)
)
compensation_filter = jobs::CompensationFilter.new type: "UNIT_AND_AMOUNT",
units: ["HOURLY"],
range: compensation_range
Expand Down