feat(dialtesting): extend Lightpanda browser checks - #204
Merged
Conversation
leecha
self-requested a review
August 12, 2026 02:48
leecha
approved these changes
Aug 12, 2026
leecha
marked this pull request as ready for review
August 12, 2026 03:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
wait_for_urland make URL/title/text assertions poll until their step or script timeoutWhy
DataKit browser dial testing needs reliable redirect polling, enterprise CA trust, proxy routing, and browser-level private-network enforcement when running the Lightpanda
0.3.6-g2build. Keeping these capabilities in cliutils avoids downstream modifications to vendored source.Impact
Existing zero-value Lightpanda runner behavior remains unchanged. The new Lightpanda flags are only added when the corresponding runtime options are set. Assertions now wait for eventual consistency until timeout instead of failing on the first observation.
Validation
go test ./dialtesting/browserdial/... -count=1go test ./dialtesting/... -count=1go vet ./dialtesting/...golangci-lint run --fix ./dialtesting/browserdial/...(0 issues)python copyright.py --dry-rungit diff --checkFull-repository lint on the Windows host is blocked by existing platform-specific
systemsyscall type-check errors; the changed browserdial packages lint cleanly.