feat(ui): move dark theme toggle into view options menu (#903) - #979
Open
DashratRajpurohit wants to merge 1 commit into
Open
feat(ui): move dark theme toggle into view options menu (#903)#979DashratRajpurohit wants to merge 1 commit into
DashratRajpurohit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves Part 1 of #903 (Clean up Phoenix bar): Moves the Dark Theme toggle directly into the View Options menu (
ViewOptionsComponent) and removes the standalone dark theme button from the primary bottom menu bar to reduce interface clutter.Visual Changes & Screenshots
Light Theme & Clean Toolbar
Dark Theme Active on ATLAS Detector
Highlights:
<app-dark-theme>button fromui-menu.component.html, opening up toolbar space.[✓] Dark ThemeMaterial checkbox directly inside the View Options dropdown menu (view-options.component.html).UIManagerdark mode state across 3D detector viewports.Changes Made
ViewOptionsComponent:darkThemestate property initialized fromUIManager.getDarkTheme().setDarkTheme(change: MatCheckboxChange)handler to toggle dark theme.view-options.component.html.view-options.component.test.ts.ui-menu.component.html:<app-dark-theme>component tag from the main bottom menu wrapper.Test Plan
view-options.component.test.ts.http://localhost:4200/andhttp://localhost:4200/atlas.