Document record-structure dictionary counts on describe_table - #633
Draft
kriszyp wants to merge 2 commits into
Draft
Document record-structure dictionary counts on describe_table#633kriszyp wants to merge 2 commits into
kriszyp wants to merge 2 commits into
Conversation
Companion to harper core's observability change for HarperFast/harper#2220. Explains what a record structure is, why the dictionary only grows, what reaching the bound means, and how to keep the dictionary small. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the 'describe_table' API documentation to detail the new record-structure dictionary fields in the response. The reviewer suggested adding a version badge to indicate this behavior change, as per the repository's documentation guidelines.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-633 This preview will update automatically when you push new commits. |
Repo convention (AGENTS.md): behavior changes to an existing surface carry `<VersionBadge type="changed" version="vX.Y.0" />`. Patch-level badges have precedent in reference/ (v5.1.5, v5.1.13, v5.1.15), and main is at 5.2.4. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-633 This preview will update automatically when you push new commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the core change for HarperFast/harper#2220 — Per-table msgpackr structure dictionaries grow unbounded and unobservably, which adds four fields to
describe_table:typed_structures_enabled,typed_structure_count,typed_structure_limit,classic_structure_count.Documents what a record structure is, why the dictionary only ever grows, what reaching the bound means, and how an application keeps it small.
For the human reviewer
{a, b}and{b, a}are different shapes, and so are{v: 1}and{v: 70000}. This is measured against the installed deps, not inferred: 4 key orders → 4 structures; one two-field shape across 11 value kinds → 5 structures. The issue that prompted this attributed growth to realized field subsets alone, which understates it.typed_structures_enabledneeds the surrounding sentence.storage.randomAccessFieldsdefaults off, so most tables showtyped_structure_count: 0against a limit of 256. Without the explanation an operator reads that as spare headroom rather than the feature being disabled, so the paragraph saying so is load-bearing.table-sizemetric; that metric turns out to have no RocksDB emitter at all (The table-size analytics metric is never emitted on RocksDB harper#2249), so documenting it here would point operators at a series that never appears.Verification
Prettier clean. Claims cross-checked against the core diff and against live measurements from the core PR's integration suite (a saturated table reports
typed 256/256,classic 32).