Add Theographic biblical entity data (people, places, events, groups) - #64
Open
VictorUvarov wants to merge 1 commit into
Open
Add Theographic biblical entity data (people, places, events, groups)#64VictorUvarov wants to merge 1 commit into
VictorUvarov wants to merge 1 commit into
Conversation
…roups) Expose the Theographic Bible Metadata dataset through the existing dataset abstraction at /api/d/theographic/. Adds an import-bible-metadata CLI command, a DatasetEntity table, generated list/detail JSON endpoints for people, places, events, and people groups, SDK methods, OpenAPI paths, and docs. Entities reference Bible passages by book/chapter/verse and never duplicate Bible text. Also fixes fetch-bible-metadata downloading a 404 for periods.json and makes downloadFile throw on non-OK HTTP responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work for Bible API
Exposes the Theographic Bible Metadata dataset (people, places, events, and people groups plus their relationships) through the existing dataset abstraction at
/api/d/theographic/.What's included
import-bible-metadata <dir>CLI command that converts the raw Theographic JSON (already downloaded by the existingfetch-bible-metadatacommand) into a dataset with four entity collections: 3,067 people, 1,274 places, 450 events, 23 people groups.DatasetEntitytable (datasetId,type,id,name,json,sha256) following theCommentaryProfilejson-blob pattern, with a migration./api/d/theographic/:people.json,people/{id}.json, and the same list/detail pairs forplaces,events, andgroups.available_datasets.jsongains entity list links and totals.free-use-bible-api(getDatasetPeople,getDatasetPerson, plus the place/event/group pairs), regenerated types, OpenAPI paths, and reference docs.Entities reference Bible passages as
{book, chapter, verse, endVerse?}using USFM book IDs (mapped from Theographic's OSIS IDs). Cross-entity references carry{id, name, apiLink}. All relationships (family, birth/death places, event participants/locations, group membership, event ordering) come from the source data; none are invented. IDs are stable slugs (e.g.paul_2479,jerusalem_636,saul-is-converted_326,tribe-of-benjamin).Bug fixes
fetch-bible-metadata404 when downloadingperiods.jsondownloadFile()now throws on non-OK HTTP responses instead of writing the error page to disk.Usage