feat: add remote announcements and release candidate fixes - #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
updatedAt, and opens announcement actions through the system browser;v?;1.3.0-rc.1.Why is this the right approach?
Announcements are fetched from a repository-owned JSON file, so urgent release notices and targeted RC feedback requests can be changed independently of the application release cycle. Matching and payload validation remain local and deterministic, while dismissed IDs are stored in
localStorage. Modal announcements reuse the existing modal manager and are processed sequentially, avoiding overlapping dialogs.The
semverdependency is used because prerelease ranges and channel-aware targeting are easy to implement incorrectly with custom string parsing.@types/semverprovides its TypeScript declarations, andbun-typesprovides the test/runtime globals required by the Bun test file and Node globals used by the Vite configuration.Waveform sizing is synchronized through XYFlow's node state instead of relying only on CSS. This keeps the visible node, resize outline, handles, and persisted dimensions aligned. The minimum canvas height is one 22 px time scale plus 72 px per displayed channel, while user-added height is preserved as channels are added or removed.
The VST3 reconcile fix checks whether the existing editor window is still visible before reattaching the recreated plugin instance. A deliberately closed window therefore remains closed, while an open editor survives a compatible pipeline rebuild.
Checklist
bun run checkpassescargo check --manifest-path src-tauri/Cargo.tomlpassesbun run formatleaves the tree clean#[derive(TS)]type changed)DspWorker::runPlatform coverage
bun run check;cargo check --manifest-path src-tauri/Cargo.toml;bun test tests/announcements_matcher.test.ts(15 passing tests);bun run formatand confirmed it produced no changes;The only per-OS files changed are
src-tauri/tauri.macos.conf.json,src-tauri/tauri.linux.conf.json, andsrc-tauri/tauri.windows.conf.json; each receives the samedevtools: falsewebview setting. No platform-specific audio backend was changed.