Fix packaged updater ASAR extraction handoff - #313
Conversation
|
@codex please review this PR and give me 10-20 issues if any. Categorize findings as required, recommended, or optional. |
💡 Codex Reviewhowcode/src/app/native/gitops/review/review-store.ts Lines 232 to 234 in baa97a7 For howcode/src/app/composer/composerDraftStore.ts Lines 147 to 148 in baa97a7 When a howcode/desktop/app-settings/writers.ts Lines 239 to 241 in baa97a7 Selecting the howcode/src/electron/main/updater/update-installer.ts Lines 59 to 62 in baa97a7 When installation fails, AGENTS.md reference: src/electron/main/updater/AGENTS.md:L2-L2 howcode/workers/polls/src/index.ts Lines 183 to 187 in baa97a7 With concurrent AGENTS.md reference: workers/polls/AGENTS.md:L3-L3 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
baa97a7 to
024a2df
Compare
Summary
app.asar0.1.72and0.1.72-dev.0Root cause
Electron patches Node filesystem handling for paths ending in
app.asar. The in-app updater used the JavaScript tar library inside Electron, which extracted the executable but silently omitted the packagedapp.asar. Separately, old Linux installs generated~/.local/bin/howcodeas a frozen direct-app wrapper, shadowingbunxand global package launchers.Validation
{ executable: true, asar: false }{ executable: true, asar: true }0.1.72and0.1.72-dev.0