Skip to content

Properly Multi-target Roslyn - #400

Merged
viceroypenguin merged 3 commits into
mainfrom
multi-target-roslyn
Sep 9, 2026
Merged

viceroypenguin merged 3 commits into
mainfrom
multi-target-roslyn

Conversation

@viceroypenguin

@viceroypenguin viceroypenguin commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Compatibility

    • Updated analyzer, code-fix, and source-generator packaging to support Roslyn 4.8, 5.0, and 5.9 environments.
    • Removed support for .NET 9.0; .NET 8.0, 10.0, and 11.0 remain supported.
    • Improved compatibility across supported .NET and Roslyn versions.
  • Quality Improvements

    • Added package validation against the 4.0.0 baseline.
    • Release builds now restore required tools and validate generated packages.
  • Testing

    • Expanded functional and unit test coverage to include code-fix components and version-specific Roslyn builds.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d52aef46-b66e-4460-9c98-6254459c0b06

📥 Commits

Reviewing files that changed from the base of the PR and between 1172b82 and 0451b93.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 10e0eee2-c12d-4eb6-b10e-698ccdc2fe1f

📥 Commits

Reviewing files that changed from the base of the PR and between ebc61e5 and 1172b82.

📒 Files selected for processing (2)
  • src/Immediate.Handlers.Shared/Immediate.Handlers.Shared.csproj
  • src/Immediate.Handlers/Immediate.Handlers.csproj
💤 Files with no reviewable changes (1)
  • src/Immediate.Handlers.Shared/Immediate.Handlers.Shared.csproj

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The build now targets Roslyn 4.8, 5.0, and 5.9. It removes .NET 9.0 support, packages version-specific analyzer assemblies, updates test references, enables package validation, and validates packages in the release workflow.

Changes

Roslyn target framework packaging

Layer / File(s) Summary
Framework and dependency matrix
Directory.Build.props, Directory.Packages.props, src/Immediate.Handlers.Shared/Immediate.Handlers.Shared.csproj
The repository removes .NET 9.0 targets, updates analyzer dependencies, and removes shared-project package validation settings.
Roslyn project targets
src/Immediate.Handlers.Analyzers/Immediate.Handlers.Analyzers.csproj, src/Immediate.Handlers.CodeFixes/Immediate.Handlers.CodeFixes.csproj, src/Immediate.Handlers.Generators/Immediate.Handlers.Generators.csproj
The analyzer, code-fix, and generator projects now build for Roslyn 4.8, 5.0, and 5.9 with explicit framework metadata and updated Scriban conditions.
Package and consumer wiring
src/Immediate.Handlers/Immediate.Handlers.csproj, samples/Normal/Normal.csproj
The package enables validation, maps product target frameworks to Roslyn-specific outputs, and packages analyzer assemblies under the corresponding Roslyn directories. The sample pins analyzer references to Roslyn 5.0.
Test and release validation
tests/Immediate.Handlers.FunctionalTests/Immediate.Handlers.FunctionalTests.csproj, tests/Immediate.Handlers.Tests/Immediate.Handlers.Tests.csproj, .github/workflows/release.yml
Tests resolve analyzer assemblies by Roslyn version. The release workflow restores .NET tools and validates generated packages.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 1172b

This change retargets Roslyn analyzer assets, packages version-specific outputs, and updates associated test and release wiring. No concrete current-head merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding proper multi-target Roslyn support across project files, packaging, and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch multi-target-roslyn

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

coveralls commented Sep 9, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 34370526978

Coverage remained the same at 95.781%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1588
Covered Lines: 1521
Line Coverage: 95.78%
Coverage Strength: 2.87 hits per line

💛 - Coveralls

@viceroypenguin

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T15:14:28.693034Z ebc61e5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebc61e58db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Immediate.Handlers.Shared/Immediate.Handlers.Shared.csproj Outdated
@viceroypenguin
viceroypenguin enabled auto-merge (squash) September 9, 2026 15:19
Package Validation requires Package Version requires commit history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants