Fix dashboard asset build ordering in CI graph/inner builds - #189
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: viceroypenguin <1992555+viceroypenguin@users.noreply.github.com>
Coverage Report for CI Build 36455032098Warning No base build found for commit Coverage: 89.045%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
The
buildGitHub Actions job failed becauseImmediate.Jobs.Dashboardinner target-framework builds attempted to embedAssets/app.jsbefore dashboard frontend assets were generated. This surfaced asCS1566missing embedded resource errors acrossnet8.0/net10.0/net11.0.Build orchestration fix
EnsureDashboardClientBuildfor non-cross-targeting (inner) builds.EnsureDashboardClientBuildinvokesBuildDashboardClientviaMSBuildwithTargetFrameworkremoved, forcing the existing outer/cross-target asset build path to run before embedding.Asset inclusion dependency update
IncludeDashboardAssetsto depend onEnsureDashboardClientBuildinstead of directly depending onBuildDashboardClient.IsCrossTargetingBuildguards while eliminating the race/order gap seen in CI.