Skip to content

Fix dashboard asset build ordering in CI graph/inner builds - #189

Merged
viceroypenguin merged 2 commits into
mainfrom
copilot/fix-github-actions-build-job
Sep 28, 2026
Merged

viceroypenguin merged 2 commits into
mainfrom
copilot/fix-github-actions-build-job

Conversation

Copilot AI commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

The build GitHub Actions job failed because Immediate.Jobs.Dashboard inner target-framework builds attempted to embed Assets/app.js before dashboard frontend assets were generated. This surfaced as CS1566 missing embedded resource errors across net8.0/net10.0/net11.0.

  • Build orchestration fix

    • Added EnsureDashboardClientBuild for non-cross-targeting (inner) builds.
    • EnsureDashboardClientBuild invokes BuildDashboardClient via MSBuild with TargetFramework removed, forcing the existing outer/cross-target asset build path to run before embedding.
  • Asset inclusion dependency update

    • Updated IncludeDashboardAssets to depend on EnsureDashboardClientBuild instead of directly depending on BuildDashboardClient.
    • Preserves current IsCrossTargetingBuild guards while eliminating the race/order gap seen in CI.
<Target Name="EnsureDashboardClientBuild"
  Condition="'$(DesignTimeBuild)' != 'true' and '$(IsCrossTargetingBuild)' != 'true'">
  <MSBuild Projects="$(MSBuildProjectFullPath)"
    Targets="BuildDashboardClient"
    BuildInParallel="false"
    RemoveProperties="TargetFramework" />
</Target>

<Target Name="IncludeDashboardAssets"
  BeforeTargets="AssignTargetPaths"
  DependsOnTargets="EnsureDashboardClientBuild"
  Condition="'$(IsCrossTargetingBuild)' != 'true'">

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 70f425af-56fe-4d9c-bf80-8dcdd36e0fc8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: viceroypenguin <1992555+viceroypenguin@users.noreply.github.com>
@viceroypenguin
viceroypenguin marked this pull request as ready for review September 28, 2026 17:02
Copilot AI changed the title [WIP] Fix failing GitHub Actions job build Fix dashboard asset build ordering in CI graph/inner builds Sep 28, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 36455032098

Warning

No base build found for commit 61e1c7a on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 89.045%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 13410
Covered Lines: 11941
Line Coverage: 89.05%
Coverage Strength: 2.88 hits per line

💛 - Coveralls

@viceroypenguin
viceroypenguin merged commit 7558636 into main Sep 28, 2026
3 checks passed
@viceroypenguin
viceroypenguin deleted the copilot/fix-github-actions-build-job branch September 28, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants