Show worker information on dashboard servers page - #191
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe dashboard now renders server cards with sorted worker details. Cards show server ID, heartbeat, worker counts, and each worker’s idle or active status. Active workers link to job details. A component test covers idle and active workers. ChangesServer worker details
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dashboard adds sorted worker status and active-job navigation without changing backend contracts. No concrete merge-blocking issue is identified; merge after normal checks pass. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Show one slot per worker and list only busy workers, so cards stay short at the default of up to 32 workers.
Coverage Report for CI Build 36726283328Coverage increased (+0.2%) to 89.007%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Closes #186
Summary
ServersViewinto a newServerCardcomponent.JobServerSnapshot.workers), filled when the worker is busy. Hovering shows the worker and job; clicking a busy slot opens the job's detail page.No backend changes were needed: the servers endpoint already serializes
Workers, and the clientcontracts.tsalready typed it.Testing
npm run check(lint, typecheck, vitest) passesnpm run build/npm run sizepassSummary by CodeRabbit