Skip to content

Link batched jobs to their batch from the job detail page - #196

Merged
viceroypenguin merged 1 commit into
mainfrom
job-detail-batch-link
Sep 30, 2026
Merged

viceroypenguin merged 1 commit into
mainfrom
job-detail-batch-link

Conversation

@dukesteen

Copy link
Copy Markdown
Contributor

Summary

The job detail page showed a job's batch handle as plain text. It is now a link to the batch detail page, in the same style as the batch links in the jobs tables (layers icon plus handle).

When JobDetail is rendered in the batch page's side panel, the handle stays plain text (showBatchLink: false), because you are already on that batch.

Tests

  • Added a test covering both the link and the plain-text case inside a batch.
  • The JobDetail tests now mount with a router through a small mountJobDetail helper.
  • npm run check passes (28 tests).

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9b975609-086a-426d-a6a1-f22b6cdcdc08

📥 Commits

Reviewing files that changed from the base of the PR and between 523e1bc and 4a0ce5d.

📒 Files selected for processing (4)
  • src/Immediate.Jobs.Dashboard/DashboardClient/src/components/JobDetail.vue
  • src/Immediate.Jobs.Dashboard/DashboardClient/src/styles.css
  • src/Immediate.Jobs.Dashboard/DashboardClient/src/views/BatchDetailView.vue
  • src/Immediate.Jobs.Dashboard/DashboardClient/tests/components.test.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@viceroypenguin
viceroypenguin merged commit 2fe7856 into main Sep 30, 2026
2 checks passed
@viceroypenguin
viceroypenguin deleted the job-detail-batch-link branch September 30, 2026 16:24
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 36742690298

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.3%) to 89.128%

Details

  • Coverage increased (+0.3%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
src/Immediate.Jobs.LinqToDB/LinqToDBJobStorage.cs 1 88.1%

Coverage Stats

Coverage Status
Relevant Lines: 13410
Covered Lines: 11952
Line Coverage: 89.13%
Coverage Strength: 2.89 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants