Link batched jobs to their batch from the job detail page - #196
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 36742690298Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.3%) to 89.128%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Summary
The job detail page showed a job's batch handle as plain text. It is now a link to the batch detail page, in the same style as the batch links in the jobs tables (layers icon plus handle).
When
JobDetailis rendered in the batch page's side panel, the handle stays plain text (showBatchLink: false), because you are already on that batch.Tests
JobDetailtests now mount with a router through a smallmountJobDetailhelper.npm run checkpasses (28 tests).