FreeRTOS: fix SIGSEV on shutdown by checking if heapTrackingAlive#197
Merged
Conversation
On shutdown some global variables are cleaned up. In our case it is the `allocatedMemory` global variable. Check if the heap tracking is still possible by logging the bool variable `heapTrackingAlive` to `false` on destructor. Then we can ignore heap tracking as the `allocatedMemory` map is already freed. Co-authored-by: https://github.com/sofar
Collaborator
Author
|
@sofar I applied your patch. Could you verify my commit message if I understood it correctly? |
Closed
|
Yeah, that looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On shutdown some global variables are cleaned up. In our case it is the
allocatedMemoryglobal variable.Check if the heap tracking is still possible by logging the bool variable
heapTrackingAlivetofalseon destructor. Then we can ignore heap tracking as theallocatedMemorymap is already freed.Patch provided by @sofar in #190 (comment)
Co-authored-by: https://github.com/sofar
Fixes: #190