chore: upgrade okhttp to 4.12.0 - #21
Open
Vligai wants to merge 1 commit into
Open
Conversation
com.squareup.okhttp 2.7.5 is end of life with no further releases. Move to com.squareup.okhttp3 4.12.0, the last line supporting the Java 8 target. - drop the unused logging-interceptor dependency - ApiClient: okhttp3 imports, RequestBody.create argument order, and HttpUrl.get instead of parse so a malformed base URL throws rather than hitting a null pointer - add ApiClientTest covering the four verbs, headers, query params, error bodies and TLS hostname verification via MockWebServer, so the transport layer has coverage without credentials - run ApiClientTest in the credential-free docker compose target Breaking: ApiClient.getClient() now returns okhttp3.OkHttpClient.
|
💬 Discussion in Slack: #pr-review-java-sdk-21-chore-upgrade-okhttp-to-4-12-0 Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
| Filename | Overview |
|---|---|
| pom.xml | Upgrades OkHttp to 4.12.0, removes the old interceptor, and adds test-scoped MockWebServer and TLS dependencies without introducing a reachable dependency vulnerability. |
| src/main/java/com/infisical/sdk/api/ApiClient.java | Migrates transport APIs to okhttp3 while preserving request behavior and replacing nullable malformed-URL parsing with an explicit exception. |
| src/test/java/com/infisical/sdk/api/ApiClientTest.java | Adds focused local-server coverage for requests, responses, authentication headers, error handling, and TLS hostname and trust validation. |
| docker-compose.yaml | Adds ApiClientTest to the credential-free unit-test command. |
Reviews (1): Last reviewed commit: "chore: upgrade okhttp to 4.12.0" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.squareup.okhttp 2.7.5 is end of life with no further releases. Move to com.squareup.okhttp3 4.12.0, the last line supporting the Java 8 target.
Breaking: ApiClient.getClient() now returns okhttp3.OkHttpClient.