Skip to content

feat(folders): add support for missing operations - #58

Open
adilsitos wants to merge 1 commit into
mainfrom
feat/adilsitos/eng-5531
Open

feat(folders): add support for missing operations #58
adilsitos wants to merge 1 commit into
mainfrom
feat/adilsitos/eng-5531

Conversation

@adilsitos

Copy link
Copy Markdown

Run the tests with valid values on the .env

@linear

linear Bot commented Aug 13, 2026

Copy link
Copy Markdown

ENG-5531

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-python-sdk-official-58-feat-folders-add-support-for-missing-operations

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds update and delete operations to the folders resource, along with typed response models and example coverage.

  • Adds response types for folder update and deletion payloads.
  • Adds update_folder and delete_folder client methods matching the existing request-layer conventions.
  • Extends the example flow to create, rename, retrieve, list, and delete a folder.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete functional or security defects identified in the changed paths.

The new folder methods match the endpoint request and response contracts, preserve optional-field semantics through the existing request layer, and do not introduce a reachable SSRF path.

Important Files Changed

Filename Overview
infisical_sdk/api_types.py Adds response wrappers and folder item models matching the update and delete endpoint payload shapes.
infisical_sdk/resources/folders.py Adds public update and delete methods with request paths, bodies, and return handling consistent with sibling resources.
sink/example.py Adds an end-to-end example that creates, updates, reads, lists, and removes a uniquely named folder.

Reviews (1): Last reviewed commit: "feat: add support for folders" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants