NRCL-104 Add read-only paper journal queries - #38
Conversation
📚 Documentation Status✅ Code changes detected
This comment is automatically generated by the documentation workflow. |
|
@codex review |
|
Linked to Plane Work Item(s) References This comment was auto-generated by Plane |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f07bc48a92
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 918beaf442
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Review fixes are in 0a1e5fe: comparison now requires equal order quantity and returns derived totals under each job's |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a1e5fe734
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Final fixes at 3aa452f: fill events require a present valid fee; stored result values must be JSON text, rejecting malformed BLOBs explicitly. Query regressions: 26 passed. Full suite: 437 passed, 6 skipped. Ruff and mypy passed; rebuilt isolated-wheel workflow passed. Earlier quantity, identity, decimal and SQLite contention fixes remain covered. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3aa452f93e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Candidate 22d8800 addresses remaining findings: strict finite JSON, valid error/status combinations, input recovery independent of output decoding, and explicit pre-open rejection of WAL archives to avoid sidecar writes. The documented journal-mode boundary requires callers not to replace the file or change mode during reads. Full suite 445 passed, 6 skipped; 34 query regressions passed; Ruff/mypy, docs/examples and rebuilt installed-wheel journey passed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22d88006b7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review 3747432 addresses the latest three findings: parse_float rejects overflow, history validates result presence without loading traces, and non-fill events cannot contribute nonzero fees. Full suite 451 passed, 6 skipped; query checks 40 passed; Ruff/mypy and rebuilt installed-wheel workflow passed. Earlier review fixes remain covered. This API intentionally preserves historical reports as recorded rather than certifying/recomputing their semantic correctness, as documented. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Consumers currently need Neural's SQLite schema to reopen saved paper experiments and reconstruct fair comparisons. This adds the experimental
neural.paper_query.PaperJournalAPI for bounded history, inspection, verified source bytes, same-input strategy comparison, and separate sports-terms comparison.Queries use read-only snapshots without reserving a writer, initializing/migrating journals or running jobs. Saved reports and content identities stay unchanged; derived totals live in each job's
summary. Comparison fixes recording, model, market/outcome, quantity, cash, fees and simulation limits while allowing thresholds and risk caps to vary. Exact decimal products and retryable SQLite busy errors are preserved; incomplete fees and malformed stored results fail explicitly.NRCL-104. NRCL-105 consumer migration follows the reviewed and merged API.
Validation at
37474320e471416e4a8551525d97fa84705d9f97:25c0d18ec510025a7c0ed2ee2e852f8b04e31b2d5ec01dda3124924c8eb60fe3.All nine final-head hosted checks passed. Exact-head Codex review reported no major issues; no unresolved threads. No release, deployment, real-data capture or live execution. User approved merge; merged as f5a5bd1.
Archive boundary: only rollback-journal databases are supported. WAL-format archives are rejected before opening SQLite so queries do not create sidecars; callers must not change journal mode or replace the file during a read. Invalid constants and error/status values reject explicitly. Recording recovery validates input independently of malformed result JSON.