Fix for 235 and maybe 242 + NPE fix for accessing userId in FileComment subtypes. - #245
Open
janknobloch wants to merge 3 commits into
Open
janknobloch wants to merge 3 commits into
janknobloch wants to merge 3 commits into
Conversation
janknobloch
changed the title
Contributor
|
Apologies for the lack of reply, but I think the formatting/indenting was changed, so I can't review, maybe you can push again while retaining the original style ? |
Contributor
|
@janknobloch: Could you look again to this PR? |
jevanlingen
added a commit
to jevanlingen/simple-slack-api
that referenced
this pull request
May 6, 2019
Because PR [Itiviti#245] is not updated for a year, I just did a diff between resources and updated the files accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe fixes : #242
fixes: #235
not in a nice way, however does the trick.
Also fixed an NPE when trying to access userId inside a FileComment, which ends up with NPE.