release: prepare TROVE 1.0.0 - #6
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ed892d863
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: | | ||
| set -euo pipefail | ||
| test "$GITHUB_REF_NAME" = "v1.0.0" | ||
| ./scripts/trove-python scripts/build_distribution.py --out dist |
There was a problem hiding this comment.
Restore a clean checkout before building the release
The preceding check.py release ends by running benchmark_agent_runtime.py, whose default output rewrites the tracked docs/perf/agent-runtime-budgets.json with the current SHA and measurements. Thus, whenever the gate succeeds, this build records source_dirty=true; verify_distribution.py currently accepts either boolean, so the following step publishes a distribution that violates the source_dirty=false release invariant and is rejected by the closeout checks. Write the benchmark artifact to a temporary path or restore it, then assert the checkout is clean before building.
Useful? React with 👍 / 👎.
Summary
Verification
./scripts/trove-python scripts/check.py contract./scripts/trove-python scripts/privacy_scan.py ../scripts/trove-python scripts/check.py releasethrough e2e and acceptance; Python 3.14 perf-help failure fixed and perf gate rerun successfully