Neutron compatibility expansion#9
Draft
JSYoo5B wants to merge 5 commits into
Draft
Conversation
JSYoo5B
commented
Jul 2, 2026
| return | ||
| } | ||
|
|
||
| routerInterface, err := h.service.AddRouterInterface( |
Owner
Author
There was a problem hiding this comment.
Router interface add/remove is the main behavior-oriented Neutron endpoint in this PR. Plain CRUD resources follow the existing pattern, but this path models an action on an existing router.
JSYoo5B
commented
Jul 2, 2026
| respond.Error(w, http.StatusNotFound, "router not found") | ||
| return | ||
| } | ||
| if errors.Is(err, appnetwork.ErrRouterInterfaceNotFound) { |
Owner
Author
There was a problem hiding this comment.
Remove distinguishes a missing router from a missing interface attachment. That distinction is useful for compatibility tests because both errors map to 404 but describe different state problems.
JSYoo5B
force-pushed
the
codex/08-neutron-compatibility-expansion
branch
from
a23d09d to
ac36a97
Compare
JSYoo5B
force-pushed
the
codex/07-nova-compatibility-expansion
branch
from
0ef73a7 to
254fa50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main Review Points
Verification