RobotError is waldoctl's; waldoctl pin -> v0.11.1 - #8
Closed
Jepson2k wants to merge 2 commits into
Closed
Conversation
A frontend represents a refused command the same way whichever backend raised it, so the refusal type is the contract's. Same six fields, same wire list in both directions, and an exception rather than a dataclass, so a client can raise it as-is. make_error, the catalog and extract_robot_error are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Bo12kumRx9PHnY9bL8qgn
RobotError serialises back to the wire and survives copy/pickle, which the controller's state snapshot needs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Bo12kumRx9PHnY9bL8qgn
Owner
Author
|
Superseded: the branch is renamed to feat/thin-python-binding so the cross-repo CI branch-matching resolves it (waldoctl <- par6 <- Waldo-Commander all use that name). Same commits, continued in the new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A frontend represents a refused command the same way whichever backend raised it, so the refusal type is the contract's:
parol6.RobotErroris nowwaldoctl.RobotError. Same six fields, same wire list in both directions, and an exception rather than a dataclass, so a client can raise it as-is.make_error, the catalog andextract_robot_errorare unchanged.One call site changed with it: the controller re-attributed a tool error with
dataclasses.replace, which an exception cannot take; it rebuilds from the wire fields instead. No test reaches that path — that gap was there before and is still there.Verified against waldoctl
v0.11.1plus Jepson2k/waldoctl#19 (which addsto_wireand makes the class copy/pickle-safe — parol6's state snapshot deepcopies it): 194 unit and 79 integration tests pass. Neither parol6 nor Waldo Commander used the sync-wrapper classes waldoctl'sv0.11.0removed andv0.11.1restored;make_sync_toolis unchanged in signature.The pin moves from
v0.7.0tov0.11.1; it should move tov0.11.2once waldoctl#19 is tagged.🤖 Generated with Claude Code
https://claude.ai/code/session_014Bo12kumRx9PHnY9bL8qgn