ASAN/compile fixes - #2
Merged
Jinming-Hu merged 1 commit intoAug 7, 2026
Merged
Jinming-Hu merged 1 commit into
Jinming-Hu merged 1 commit into
Conversation
mahmood-openai
commented
Aug 6, 2026
| #pragma once | ||
|
|
||
| #include <azure/core/http/policies/policy.hpp> | ||
| #include <azure/storage/common/internal/constants.hpp> |
Author
There was a problem hiding this comment.
Needed for HttpHeaderXMsVersion usage below.
mahmood-openai
commented
Aug 6, 2026
| private: | ||
| Azure::Core::_internal::UniqueHandle<CURL> m_handle; | ||
| Azure::Core::_detail::UniqueCURLSHHandle m_sslShareHandle; | ||
| Azure::Core::_internal::UniqueHandle<CURL> m_handle; |
Author
There was a problem hiding this comment.
ASAN caught a lifetime issue here, m_handle references m_sslShareHandle, so let's destroy m_handle first.
Jinming-Hu
added a commit
to Azure/azure-sdk-for-cpp
that referenced
this pull request
Aug 7, 2026
…rsion_policy (#7297) storage_service_version_policy.hpp uses HttpHeaderXMsVersion which is declared in azure/storage/common/internal/constants.hpp, but did not include that header and relied on transitive includes. Add the include directly (include-what-you-use). Original author of this fix: @mahmood-openai (surfaced in Jinming-Hu#2). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 773f0ec9-93bb-4894-97ed-cf4ad4302896
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed these changes to get bifrost client to compile and run cleanly under asan