Skip to content

brain approve transacional + external discovery policy #5

Description

@JonathLima

What to build

Make brain approve transactional: activates a skill AND updates the inventory in one operation. Enforce external discovery policy.

Scope

  • brain.rs: approve_candidate now also writes approved skill to inventory (atomic: move files + update inventory or rollback)
  • Reject any _pending skill references in inventory operations
  • External discovery: requires explicit policy flag + prior approval with origin, hash, trust, scope fields. BRAIN adapts only when a real skill gap exists, never modifies global skills
  • Remove skill scan step after brain approve (inventory already updated by approve_candidate)
  • Tests: approve adds to inventory, rollback on failure, external discovery without policy rejected, _pending rejected

Acceptance criteria

  • cargo test -p orquestra-skills passes
  • brain approve moves skill from _pending to .orquestra/skills/ AND adds to skills_inventory.md
  • skill list shows approved skill without requiring skill scan
  • External discovery without policy flag is rejected
  • BRAIN does not modify global skills (~/.agents/skills/)
  • Rollback on failed approve restores prior state

Blocked by

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions