Fixes for the ClamAV Yara generator - #67
Merged
Merged
Conversation
added 6 commits
July 22, 2026 10:04
… are being parsed. Added a section to rewrite logical expressions that start with 0:, as the colon is not in any documentation, and the second half is valid
…s in the conditions
Author
|
Also the contributing guidelines https://docs.manalyzer.org/en/latest/before-contributing.html contain a style guide for the C++ part of the project, but nothing for the python side. I tried to emulate the existing style as much as I could |
Owner
|
Thanks a lot for these fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ClamAV rules were not parsing properly, causing any scans using the ClamAV plugin to fail, as the rules could not be compiled. This PR specifically fixes 4 cases that were preventing compilation as of 22/07
I also added a -q/--quiet flag to both scripts, which suppresses the "Rule seems to be malformed" and "Unable to translate a logical signature" messages, as they made it hard to find debug information relevant to the bugs I was trying to fix
After adding these fixes, I can successfully process one of my own files using the ClamAV plugin with no false positives, however I do not have any malware to hand to make sure there are no false negatives.