Skip to content

flip N to Y - #227

Merged
zwright merged 1 commit into
developfrom
KPMP-6774_fix-cts-query
Jul 20, 2026
Merged

flip N to Y#227
zwright merged 1 commit into
developfrom
KPMP-6774_fix-cts-query

Conversation

@Dert1129

@Dert1129 Dert1129 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Corrected parent-region classification so records from the updated hierarchy are properly identified as reference points.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The findRTRPParentRegions native SQL now emits is_rp = 'Y' for results from rt_segment_hierarchy_2025_v.

Changes

RT parent-region classification

Layer / File(s) Summary
Update RT hierarchy classification
src/main/java/org/kpmp/cellTypeSummary/ClusterHiearchyRepository.java
The first findRTRPParentRegions query branch changes the generated is_rp literal from 'N' to 'Y'.

Possibly related PRs

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch KPMP-6774_fix-cts-query

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/main/java/org/kpmp/cellTypeSummary/ClusterHiearchyRepository.java (1)

27-27: 🎯 Functional Correctness | 🔵 Trivial

Verify cache invalidation for the changed classification.

This method uses the unchanged clusterHierarchy2025ByCellTypeRegionsSubregions cache. If the cache survives deployment, existing entries may continue returning is_rp = 'N' despite this query now emitting 'Y'. Confirm that deployment evicts/version-bumps this cache, or change the cache key/name.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 28d33fd8-a238-4697-82c3-a5f060bed393

📥 Commits

Reviewing files that changed from the base of the PR and between aa9dbf2 and 6862f47.

📒 Files selected for processing (1)
  • src/main/java/org/kpmp/cellTypeSummary/ClusterHiearchyRepository.java

@zwright
zwright merged commit fa3b4a2 into develop Jul 20, 2026
1 check passed
@zwright
zwright deleted the KPMP-6774_fix-cts-query branch July 20, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants