Add multi-channel approver support to Google Chat App setup - #2348
Merged
Conversation
* Add multi-channel approver support to Google Chat App setup * removed duplicate chat_approvals_space_id, and updates based on review comments * Fix review feedback on Google Chat multi-channel approvers -Remove duplicate FIELD_APPROVALS_SPACE_ID from record fields -Fix type annotation: any → object in _validate_service_account_dict() -Replace unsafe assert with proper CommandError error handling -Add test_multi_channel_approval_config_serialization() for multi-team coverage * Use GChat-specific naming for approvals configuration fields -Change default channel field to chat_approvals_space_id (from approvals_channel_id) -Use space_id instead of channel_id in approvals_teams JSON for teams -Create _gchat_approvals_record_fields() for GChat-specific serialization -Update tests to verify new field naming conventions * Addressed review comments:Parameterize ApprovalsChannelProfile to unify Slack/GChat schema and fix --sync-down data corruption
sk-keeper
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-channel approver support was added to Google Chat setup, providing feature parity with Slack.
Changes
ApprovalsChannelProfilewithchannel_field_nameandteam_channel_keyfields. Parameterizedapprovals_config_to_record_fields()to use profile's field names.parse_approvals_from_record(),merge_approvals_custom_fields(),sync_approvals_config(), andrun_approvals_sync_down()to accept and use profile's field names.GCHAT_APPROVALS_PROFILEwithchannel_field_name='chat_approvals_space_id'andteam_channel_key='space_id'. Implementedget_approvals_profile(). Updatedbuild_record_custom_fields()to pass profile. Replaced unsafeassertwith explicitCommandError. AddedCommandErrorimport._patch_record_approvals()andrun_approvals_sync_down()to pass profile parameter.approvalsfield REQUIRED (no default). Added@property chat_approvals_space_iddelegating toapprovals.single_channel_id. Removed duplicate constants fromGChatConstants.SLACK_APPROVALS_PROFILEto sync functions for consistency.test_multi_channel_approval_config_serialization()to pass profile and verify GChat field names (chat_approvals_space_id,space_id).