ci: KEEP-1307 stop telling contributors to re-run the gate by hand - #112
Merged
Conversation
Same correction as keeperhub: recheck-issue-link re-runs the check when an issue is labelled accepted, so the instruction to re-run the job by hand is false and is shown to a contributor who is waiting on our triage. Also drops a duplicate `main` from decision-label-check's branch list, left by the KEEP-1304 port - the keeperhub file lists staging, prod and main, and the port replaced only the first two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No GitHub issue. Team change, tracked as KEEP-1307, in the branch name and the commit.
What this changes
Two corrections to the gate ported in KEEP-1304.
The failure comment told contributors to work around a bug that no longer exists. It said the check does not re-run when an issue is labelled, and to re-run the job or edit the title by hand.
recheck-issue-link, which landed here in the same port, does that automatically. The instruction appeared twice; the worse of the two is shown to an outside contributor waiting on our own triage. Both now say the check re-runs by itself once a referenced issue is labelledaccepted.decision-label-checklistedbranches: [main, main]. The keeperhub file it was ported from carries three entries -staging,prod,main- and the port replaced only the first two. Functionally harmless, wrong as written, and now a singlemain.Scope
One unit: both edits are to workflows landed by the same port, and neither changes control flow.
How it was verified
No Go changed. Both workflows parse as YAML and their extracted
run:bodies passsh -n. Trigger and base-branch sets re-read from the parsed YAML rather than grepped:pr-issue-linkispull_request_targeton[main],decision-label-checkispull_requeston[main]. The stale phrase appears zero times.Screenshots
Renders nothing.