fix(deps): bump rustls to 0.23.45 (RUSTSEC-2026-0285) - #45
Merged
Merged
Conversation
rustls 0.23.40 is vulnerable to RUSTSEC-2026-0285 (TLS 1.3 handshake messages accepted across encryption levels), which caused the repo-wide 'Security Audit' CI job (cargo audit / make audit) to fail with exit code 2 on all open PRs against main. Resolve the lockfile to rustls >=0.23.45. Lockfile-only change. cargo audit now exits 0 (remaining entries are non-failing warnings). Co-authored-by: Ty Schenk <schenkty@users.noreply.github.com>
larseidsvoll
approved these changes
Sep 16, 2026
larseidsvoll
left a comment
larseidsvoll
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Lockfile-only fix for RUSTSEC-2026-0285 (patched >=0.23.45):
rustls0.23.40 → 0.23.45- Transitive:
rustls-webpki0.103.15,aws-lc-rs1.18.1,aws-lc-sys0.45.0 (+pkg-config)
No source changes. Prefer human-merge this before #40–#42/#44 so Security Audit can go green.
Still draft; CI in progress.
Review only — do not bot-merge (Ty lock on node-rs). Humans merge. No @ humans.
|
schenkty
marked this pull request as ready for review
September 16, 2026 01:13
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Security Audit CI (
make audit) fails repo-wide: RUSTSEC-2026-0285 onrustls0.23.40.Fix
Lockfile-only:
cargo update -p rustls --precise 0.23.45(plus required transitive bumps).Verify
make auditexits 0. Non-failing warnings (instant/anyhow/rand/spin) left alone.Human-merge this first so #40–#44 Security Audit can go green.
Note
Low Risk
Lockfile-only patch on the TLS dependency chain; no app code changes, but any rustls fix can affect TLS behavior at runtime.
Overview
Summary
Security Audit CI fails on RUSTSEC-2026-0285 for
rustls0.23.40. This updates the locked TLS stack somake auditcan pass without touching application source.Related Issues
None
Changes Made
rustlsto 0.23.45 in the lockfile (transitive crypto/TLS crates updated as required by that resolution)Testing
Run
make auditand confirm it exits 0.Breaking Changes
None
Reviewed by Cursor Bugbot for commit c7b3db8. Configure here.