Add support for Cloud Run Worker Pool Containers - #106
Merged
Merged
Conversation
Member
Author
|
@cursor review |
rkeene
marked this pull request as ready for review
July 18, 2026 05:13
rkeene
changed the base branch from
process/upgrade-to-pulumi-gcp-9-30-0
to
main
July 27, 2026 16:45
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8656a5e. Configure here.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This change adds support for Cloud Run Worker Pool Containers, which are similar to the ContainerMIG we already provide but utilize Cloud Run Worker Pools (which recently became Generally Available).
Note
Medium Risk
Touches core GCP provisioning (VPC egress/NAT, IAM, worker topology) and removes CloudRunService stack outputs, which may break downstream Pulumi consumers.
Overview
Adds Cloud Run Worker Pools as an alternative to MIG-based background workers, selectable via
mig.workerKind: 'crwp'onCloudRunService(default remains MIG).Introduces
ContainerCloudRun, which provisions acloudrunv2.WorkerPoolwith shared IAM/registry setup extracted intohandleGenericOptions. CRWP workers use Secret Manager env refs (cloudRunJobVariableOutput) instead of resolved plain env vars, and support egress modes (vpc,vpc+natwith optional Cloud NAT/router/route,vpc+direct). Incompatible MIG-only options (cosImage,enableSSH,allocateExternalIP) error whencrwpis chosen.ContainerMIGis refactored onto the shared options helper; registry IAM now targets Artifact Registry paths only (legacyartifacts.*.appspot.combucket grant removed).EnvManagerno longer emits a conflictingvaluefield when env vars use secret refs.Note:
CloudRunServiceno longer callsregisterOutputsforserviceUrl,backendService,mig, andmigrationStatusat the end of its constructor.Reviewed by Cursor Bugbot for commit eeb54f3. Bugbot is set up for automated code reviews on this repo. Configure here.