cmake: add shared library option - #350
Merged
Merged
Conversation
|
|
Contributor
Author
|
recheck |
spencer-lunarg
approved these changes
Aug 10, 2026
Contributor
|
@wolfv this looks good... not sure why github is not happy about the CLA, I tried to "recheck" it and still seems to not be working... can you try signing it again (github has REALLY had issues with the CLA server recently across the various repos I work on) |
Contributor
Author
|
OK, now CLA is green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in
SPIRV_REFLECT_SHARED_LIBCMake option alongside the existing static-library option.The shared target installs as
libspirv-reflect, installs the public header, and uses CMake automatic symbol exports on Windows. Existing defaults and the static target remain unchanged.Tested by configuring, building, and installing the shared-only target locally. This is also exercised across Linux, macOS, and Windows by conda-forge: https://github.com/conda-forge/spirv-reflect-feedstock