vulkaninfo: Error when multiple output formats are given - #1256
Merged
charles-lunarg merged 1 commit intoSep 30, 2026
Merged
Conversation
--summary, --text, --html, --json and --vkconfig_output are mutually exclusive, but previously the last one silently won. parse_arguments now records each requested format in a set and fails with an error if more than one distinct format was given. Repeating the same format is still accepted. Adds CTest cases that run vulkaninfo with conflicting format pairs and check for the error message, and documents the restriction in the help text and vulkaninfo.md.
|
Author devnu11 not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author devnu11 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Tools build queued with queue ID 137129. |
|
CI Vulkan-Tools build # 2039 running. |
charles-lunarg
approved these changes
Sep 30, 2026
charles-lunarg
left a comment
charles-lunarg
left a comment
Contributor
There was a problem hiding this comment.
Good to have a check for exclusive command line options. Thanks!
|
CI Vulkan-Tools build # 2039 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--summary, --text, --html, --json and --vkconfig_output are mutually exclusive, but previously the last one silently won. parse_arguments now records each requested format in a set and fails with an error if more than one distinct format was given. Repeating the same format is still accepted.
Adds CTest cases that run vulkaninfo with conflicting format pairs and check for the error message, and documents the restriction in the help text and vulkaninfo.md.