Multi-dimensional array support in safe struct generator - #415
Merged
spencer-lunarg merged 1 commit intoSep 29, 2026
Conversation
spencer-lunarg
approved these changes
Sep 29, 2026
Contributor
|
@nima-davari-huawei thanks, now it will be simpler when you need this for future extensions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The safe struct generator assumes
len(member.fixedSizeArray)is always 1, and it does not handle multi-dimensional arrays properly. Here is an example:float matrix[4][4];This MR adds a new code branch to handle such cases. Here is an example of what the new code would generate for the above example.
Before MR:
After MR:
Note that no auto-generated code needs to be checked in with the MR as it does not affect any existing structs.