Conversation
Contributor
|
✅ KSAI Review: Finished
Run report (federated) · 1 paid run · $0.0658 total
Reviewing cost $0.0657; deciding how to run it cost $0.0001 |
rspurgeon
had a problem deploying
to
kongctl-acceptance-2
September 16, 2026 03:56 — with
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | E2E scenario YAML: three new external-sync overlays (schema registry, static key, TLS trust bundle) and steps 020-026 in external-sync/scenario.yaml |
| Mandate | default-code-reviewer |
| Findings | 1 Low |
| Findings audit | Completed (kreview:findings-auditor; 1 kept, 0 dropped) |
The diff is test-only and mirrors established patterns in steps 006-019 and sibling scenarios. Fixtures (vault env PATH reference, static key value, TLS certificate) match existing repo fixtures. Step 026's omission assertions match base testdata behavior. No additional concerns found in the secrets, security and leak pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event-gateway external-sync scenario did not cover schema registries,
static keys, or TLS trust bundles under an API-created gateway.
Add three overlays and seven steps that verify CREATE plans and applied counts,
resource names/descriptions and type-specific fields, idempotency for all three
resources, and preservation when the child collections are omitted. Existing
scenario steps remain unchanged.
Closes #2181.
Validation:
CGO_ENABLED=0 go fix ./...,make format, andmake buildpassed.make lintpassed with zero issues.MISE_SHELLCHECK_VERSION=0.11.0 make -o lint test-allpassed: installer,race-enabled unit and integration tests, and 96 E2E tooling tests.
assertions in the CREATE plan and get output after creation and omission.
Command:
make test-e2e-scenarios SCENARIO=event-gateway/external-sync.Artifacts:
.e2e-artifacts/gh-2181-review/20260916-085747.of omitting document-start markers.
local hook issues (missing PyYAML and sandbox restrictions). Unrelated hook
edits were discarded.