Skip to content

test(e2e): verify event gateway dump excludes children by default - #2193

Merged
rspurgeon merged 1 commit into
mainfrom
gh-2182
Sep 16, 2026
Merged

rspurgeon merged 1 commit into
mainfrom
gh-2182

Conversation

@rspurgeon

Copy link
Copy Markdown
Collaborator

The filtered event-gateway dump scenario checked the parent but could miss a
regression that includes children without --include-child-resources.
Extend step 003-dump-with-filter to assert that all seven child collections
resolve to null, matching their omission from actual dump YAML. Document the
default behavior beside the step.

Fixes #2182.

Validation:

  • Passed Go modernization, formatting, build, lint (serialized to avoid another
    running linter), unit tests, integration tests, installer checks, and all 96
    E2E metrics tests.
  • Live fixture creation, the updated filtered dump assertions, and cleanup
    passed with KONGCTL_E2E_RESET=0 and step 002-dump-event-gateways skipped.
    The captured YAML confirms all seven child collection keys are omitted.
    Artifacts: /home/rspurgeon/go/e2e-artifacts/20260915-224719.
  • Full scenario attempts passed the positive child assertions but failed at
    the unchanged round-trip plan assertion (14 creates, then 7 creates, instead
    of zero changes). Another event-gateway E2E scenario was running locally and
    the fixture disappeared between runs, suggesting shared-environment
    interference; the cause is not confirmed. A clean full-scenario pass remains
    unverified. Cleanup was run successfully afterward.
    Latest full-run artifacts:
    /home/rspurgeon/go/e2e-artifacts/20260915-224759.

@rspurgeon
rspurgeon requested review from a team as code owners September 16, 2026 03:54
@kong-api-ops
kong-api-ops Bot requested a review from a team September 16, 2026 03:54
@kong-api-ops

kong-api-ops Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

KSAI Review: Finished

  1. 03:58 UTC Reading the code changes and applicable review conventions

Run report (federated) · 1 paid run · $0.0205 total
# Engine Result Model Turns Cost
1 opencode success zai-org/GLM-5.3-Flash/high 15 $0.0204

Reviewing cost $0.0204; deciding how to run it cost $0.0001

@kong-api-ops kong-api-ops Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Result
Scope Adds one assertion to an e2e dump scenario verifying child arrays are absent without --include-child-resources
Mandate default-code-reviewer
Findings None
Findings audit Skipped (no candidate findings)

No issues found. Verified against the dump implementation and the harness matcher: the seven child fields are omitempty and only populated behind the flag, and a missing key resolves to nil, which matches the expected null. The null-expectation idiom matches existing scenarios. Additional Risk pass: no additional concerns found.

@kong-api-ops
kong-api-ops Bot removed the request for review from a team September 16, 2026 04:02
@rspurgeon
rspurgeon deployed to kongctl-acceptance-3 September 16, 2026 04:06 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance-2 September 16, 2026 04:06 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance-5 September 16, 2026 04:06 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance-4 September 16, 2026 04:06 — with GitHub Actions Active
@rspurgeon
rspurgeon deployed to kongctl-acceptance September 16, 2026 04:06 — with GitHub Actions Active
@rspurgeon
rspurgeon merged commit 0b4ba7d into main Sep 16, 2026
49 checks passed
@rspurgeon
rspurgeon deleted the gh-2182 branch September 16, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[e2e-scan] Test: Improve e2e coverage for event-gateway dump child exclusion default (expand scenario)

1 participant