Conversation
Contributor
|
✅ KSAI Review: Finished
Run report (federated) · 1 paid run · $0.0205 total
Reviewing cost $0.0204; deciding how to run it cost $0.0001 |
Contributor
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | Adds one assertion to an e2e dump scenario verifying child arrays are absent without --include-child-resources |
| Mandate | default-code-reviewer |
| Findings | None |
| Findings audit | Skipped (no candidate findings) |
No issues found. Verified against the dump implementation and the harness matcher: the seven child fields are omitempty and only populated behind the flag, and a missing key resolves to nil, which matches the expected null. The null-expectation idiom matches existing scenarios. Additional Risk pass: no additional concerns found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filtered event-gateway dump scenario checked the parent but could miss a
regression that includes children without
--include-child-resources.Extend step
003-dump-with-filterto assert that all seven child collectionsresolve to null, matching their omission from actual dump YAML. Document the
default behavior beside the step.
Fixes #2182.
Validation:
running linter), unit tests, integration tests, installer checks, and all 96
E2E metrics tests.
passed with
KONGCTL_E2E_RESET=0and step002-dump-event-gatewaysskipped.The captured YAML confirms all seven child collection keys are omitted.
Artifacts:
/home/rspurgeon/go/e2e-artifacts/20260915-224719.the unchanged round-trip plan assertion (14 creates, then 7 creates, instead
of zero changes). Another event-gateway E2E scenario was running locally and
the fixture disappeared between runs, suggesting shared-environment
interference; the cause is not confirmed. A clean full-scenario pass remains
unverified. Cleanup was run successfully afterward.
Latest full-run artifacts:
/home/rspurgeon/go/e2e-artifacts/20260915-224759.